Merged
Conversation
When an embedded visualization URL references a slug that no longer exists, return a user-friendly HTML page (200) instead of Django default 404. This displays cleanly inside iframes and avoids cross-origin error handling issues. Cache headers prevent the response from being cached so the real visualization appears once re-created. Co-Authored-By: Claude Opus 4.6
Co-Authored-By: Claude Opus 4.6
The view now correctly returns 404 with friendly HTML content. Update the test to match. Co-Authored-By: Claude Opus 4.6
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 130 130
Lines 6158 6170 +12
=======================================
+ Hits 5913 5925 +12
Misses 245 245
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of #600 with a local branch to allow Heroku CI to run